Bump JtD to 0.12.0, migrate nav_footer_custom#114
Open
mattxwang wants to merge 2 commits intoberkeley-cdss:mainfrom
Open
Bump JtD to 0.12.0, migrate nav_footer_custom#114mattxwang wants to merge 2 commits intoberkeley-cdss:mainfrom
mattxwang wants to merge 2 commits intoberkeley-cdss:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Berkeley CDSS team,
I feel a bit embarrassed, but 0.11.0 broke the site footer behaviour, which in this case affects the mobile view of the credits & color scheme toggle on live:
(notice how the "view all course offerings" and dark mode toggle is overlaid on the text, instead of at the bottom of the page)
I fixed this in 0.12.0, which requires a small (but explicit) migration step. I tested with this repo locally, so the PR now fixes the overall visual behaviour of the footer. There are still some small spacing changes that are tricky to fully match the behaviour of - but I think this is pretty close to the original spacing for the element.
Sorry for this mistake - fault is completely mine. Let me know if you want me to try to more faithfully match the pre 0.11.0 styling - it's possible, but will just require a few more overrides.