in_port changes#8
Open
smiddy wants to merge 1 commit into
Open
Conversation
Owner
|
This definitely makes sense for initialization -- although I think we should either go with a variable name that makes it clear that it's just the Alternatively, we could modify the API such that the behavior for would become ... and Thoughts? |
Author
|
From my point of view the second option is preferred. We would save to introduce an additional variable and during the running it is clear which is the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in_port as input variable. Would be nice to have it as variable for initialization. What do you think?