Skip to content

in_port changes#8

Open
smiddy wants to merge 1 commit into
benpruitt:masterfrom
smiddy:in_port
Open

in_port changes#8
smiddy wants to merge 1 commit into
benpruitt:masterfrom
smiddy:in_port

Conversation

@smiddy
Copy link
Copy Markdown

@smiddy smiddy commented Nov 12, 2015

in_port as input variable. Would be nice to have it as variable for initialization. What do you think?

@smiddy smiddy changed the title in_port changes in_port changes. Fixes #7 Nov 12, 2015
@smiddy smiddy changed the title in_port changes. Fixes #7 in_port changes Nov 12, 2015
@benpruitt
Copy link
Copy Markdown
Owner

This definitely makes sense for initialization -- although I think we should either go with a variable name that makes it clear that it's just the in_port for initialization (init_in_port?).

Alternatively, we could modify the API such that the behavior for in_port is the same as the behavior for out_port. For example:

extractToWaste(self, in_port, volume_ul, out_port=None,
                          speed_code=None, minimal_reset=False, flush=False)

would become

extractToWaste(self, volume_ul, in_port=None, out_port=None,
                          speed_code=None, minimal_reset=False, flush=False)

... and in_port would default to self.in_port in the same way that out_port defaults to self.waste_port

Thoughts?

@smiddy
Copy link
Copy Markdown
Author

smiddy commented Nov 18, 2015

From my point of view the second option is preferred.

We would save to introduce an additional variable and during the running it is clear which is the in_port by definition of self.in_port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants