Add a configurable delay for starting worker timeout checks #3437
+117
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddpalino
force-pushed
the
3436-timeout-delay
branch
from
8ef0ff0 to
d3b0a0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Described in #3436
This adds a configuration parameter timeout_delay which allows a user to specify a grace period for workers to start notifying that they are live. This decouples the time it takes a worker to start up from the time to detect a problem after it is running. The default does not change the existing behavior - if the configuration is not specified, no delay is added.
The delay works by adding time to the initial creation of the WorkerTmp notification file. The arbiter will evaluate the notification as good until the delay period expires. If the worker starts notifying before that period expires, it effectively cancels the rest of the delay.