Migrate from Travis CI to GitHub CI #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List of additional changes: - prettify README - resolve compiler warnings from tests - resolve dialyzer warnings - use ex_doc for doc generation
kianmeng
commented
Sep 25, 2025
| %% API | ||
| -export([to_ascii_test/0, to_unicode_test/0]). | ||
|
|
||
|
|
Author
There was a problem hiding this comment.
$ rebar3 eunit
===> Verifying dependencies...
===> Analyzing applications...
===> Compiling idna
┌─ test/punycode_test.erl:
│
8 │ -export([punicode_encode_test/0, punicode_decode_test/0]).
│ ╰── Warning: function punicode_decode_test/0 already exported
┌─ test/punycode_test.erl:
│
8 │ -export([punicode_encode_test/0, punicode_decode_test/0]).
│ ╰── Warning: function punicode_encode_test/0 already exported
┌─ test/compat_test.erl:
│
9 │ -export([to_ascii_test/0, to_unicode_test/0]).
│ ╰── Warning: function to_ascii_test/0 already exported
┌─ test/compat_test.erl:
│
9 │ -export([to_ascii_test/0, to_unicode_test/0]).
│ ╰── Warning: function to_unicode_test/0 already exported
┌─ test/uts46_test.erl:
│
127 │ to_unicode(S) ->
│ ╰── Warning: function to_unicode/1 is unused
===> Performing EUnit tests...
...............
kianmeng
commented
Sep 25, 2025
| Dir = idna_data:bidirectional(C), | ||
| case lists:member(Dir, ["R", "AL", "AN"]) of | ||
| true -> true; | ||
| false -> check_rtl(Rest, Label) |
Author
There was a problem hiding this comment.
rebar3 dialyzer
===> Verifying dependencies...
===> Analyzing applications...
===> Compiling idna
===> Dialyzer starting, this may take a while...
===> Add debug_info to compiler options (erl_opts) if Dialyzer fails to load Core Erlang.
===> Updating plt...
===> Resolving project files...
===> Updating base plt...
===> Resolving base files...
===> Checking 222 files in /home/ang/.cache/rebar3/rebar3_28.1_plt...
===> Copying /home/ang/.cache/rebar3/rebar3_28.1_plt to /home/ang/src/contrib/eef/erlang-idna/_build/default/rebar3_28.1_plt...
===> Checking 222 files in _build/default/rebar3_28.1_plt...
===> Doing success typing analysis...
===> Resolving project warning files...
===> Analyzing 8 files with _build/default/rebar3_28.1_plt...
src/idna.erl
Line 373 Column 1: The pattern <Char, <<>>> can never match the type <string() | char(),[any()]>
Line 374 Column 1: The pattern <Char, <<>>> can never match the type <string() | char(),[any()]>
Line 375 Column 24: Guard test is_binary(Bin::[any()]) can never succeed
src/idna_bidi.erl
Line 28 Column 5: The pattern 'false' can never match the type [1..255,...]
===> Warnings written to _build/default/28.1.dialyzer_warnings
===> Warnings occurred running dialyzer: 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of additional changes: