Skip to content

fix: reduce false positives in imperative verb detection #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benner merged 1 commit into from
Mar 22, 2026
Merged

fix: reduce false positives in imperative verb detection #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/git_commit_guard/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,10 @@ def check_imperative(desc, result):
first = tokens[0]
if first in IMPERATIVE_VERBS:
return
tagged = nltk.pos_tag(tokens)
if tagged[0][1] != "VB":
tagged = nltk.pos_tag(["i", *tokens])
if tagged[1][1] not in {"VB", "VBP"}:
result.error(
f"expected imperative verb, got '{tagged[0][0]}' (POS={tagged[0][1]})",
f"expected imperative verb, got '{tagged[1][0]}' (POS={tagged[1][1]})",
)


Expand Down
5 changes: 5 additions & 0 deletions tests/test_git_commit_guard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,11 @@ def test_non_whitelist_imperative_passes(self):
check_imperative("refactor authentication module", r)
assert r.ok

def test_write_imperative_passes(self):
r = Result()
check_imperative("write unit tests", r)
assert r.ok

def test_empty_desc_passes(self):
r = Result()
check_imperative("", r)
Expand Down