ci: replace backend-e2e with e2e-docker and introduce playwright-e2e workflows#184
Open
Gill87 wants to merge 55 commits into
Open
ci: replace backend-e2e with e2e-docker and introduce playwright-e2e workflows#184Gill87 wants to merge 55 commits into
Gill87 wants to merge 55 commits into
Conversation
…o 'Confirm' for improved clarity
…ging in files to import
…make vehicle and delivery subheaders smaller
…ng up the start location to be displayed in the results page
…ts page can integrate both components
…es field at every change
…that are too large to save
…related components
…ptimizer into ci/new-checks
…isco health check by using env variables to use monach health check in e2e-docker ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backend-e2ejob inpr-light.ymlwith dedicated weekly/manual CI workflows for backend Docker E2E and Playwright UI E2E.ctest -L e2esuite on native ARM64; Playwright exercises landing → edit → optimize → results against a live Docker stack and C++ API.OSRM_HEALTHCHECK_LON/OSRM_HEALTHCHECK_LAT(Monaco for backend E2E, San Francisco for Playwright).Motivation
backend-e2eran the same slow Docker tests on every push tomainusing x86 + QEMU for an ARM64 stack—slow, less production-like, and without failure diagnostics.e2e|dockerfor speed; we still need a canonical backend integration path and a browser-level smoke test for the route-manager flow.ctestE2E by validating the UI against real routing services.Changes
Infrastructure / CI
.github/workflows/e2e-docker.yml: weekly +workflow_dispatch,ubuntu-24.04-arm,ctest -L e2e, compose preflight, 240m timeout, failure diagnostics artifact..github/workflows/playwright-e2e.yml: weekly +workflow_dispatch, SF OSRM cache, compose override, Next.js build/start,npm run test:e2e, Playwright report on failure.backend-e2efrom.github/workflows/pr-light.yml; fastpr-checksunchanged (-LE 'e2e|docker').Backend / deploy
deploy/compose/docker-compose.arm64.yml.deploy/compose/docker-compose.e2e-override.ymlfor Playwright OSRM cache volume.tests/integration/e2e/e2e_stack.env(Monaco healthcheck); addtests/integration/e2e/e2e_sf_playwright.env(SF PBF, amd64).Frontend (Playwright + edit hi-fi)
app/ui/playwright.config.ts,app/ui/tests/e2e/optimize-flow.spec.ts, andtest:e2escript.formStyles.v2.ts, shared navbar/sidebar components, CSV upload overlay, error overlays, drag-drop import, and related edit/results wiring.Validation
cmake --preset devcmake --build --preset dev --parallelctest --preset dev --output-on-failure --no-tests=error -LE 'e2e|docker'Frontend
npm --prefix app/ui run lintnpm --prefix app/ui run format:checknpm --prefix app/ui run typechecknpm --prefix app/ui run testnpm --prefix app/ui run buildnpm --prefix app/mobile run lintnpm --prefix app/mobile run typecheckBackend
.github/scripts/check-backend-static.sh build/devdocker compose -f deploy/compose/docker-compose.arm64.yml --env-file deploy/env/http-server.arm64.env configNew CI workflows (post-merge / manual)
gh workflow run e2e-docker.ymlgh workflow run playwright-e2e.ymlIntentionally skipped on PR CI:
ctest -L e2eandnpm run test:e2e(covered by dedicated workflows).Risk
pull_requestor everymainpush; regressions may surface only on the weekly schedule or manual dispatch.e2e-docker.ymlrequiresubuntu-24.04-arm; Playwright useslinux/amd64onubuntu-latest—rare arch-specific failures may appear in only one workflow.Rollout and Recovery
gh workflow run e2e-docker.ymlandgh workflow run playwright-e2e.ymlfor smoke validation.backend-e2eonmainpushes if weekly E2E cadence is insufficient.