Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Loosen DEFAULT_OPTIONS typing on Vue mixin base classes so subclass override literals aren't checked against the full merged shape, type ApplicationV2/ActorSheetV2/ItemSheetV2 shims as constructor-shaped (extending a bare `any` collapses the constructor signature to zero args in TS) instead of plain `any`, and clear a handful of unrelated gaps left by the v13 type shims (Game.release.generation, FormData iteration, sheet lookup typing).
Rewrite sass-chroma-js.ts and custom-icons.ts (plus their shared sass-assert/sass-convert helpers) to Dart Sass's modern compileStringAsync API, and switch vite.config.ts's scss preprocessor to api: 'modern'. This removes the "legacy-js-api" deprecation warning on every build. Verified the generated ironsworn.css is byte-for-byte identical to the legacy-API build (after rounding RGB channels to match the old getR()/getG()/getB() precision, since the modern API returns exact fractional channel values).
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Add icons for Progress, Vow and Connection tracks
and switch fully to pnpm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accidentally "merged" #1086, this is a reconstruction of that PR on a non-main branch.