'CleanupOrFail': Cleanup but returns error if it would cleanup with -u #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd rather know early if there are snapshots that need cleaning up, rather than finding out while adding something unrelated. Keeps things tidy. I thought of giving Cleanup() this behaviour directly, but suspected a breaking change like that would not be welcome. So instead I wrote its wacky sister function. If you see the name, cringe, and think of a better one, speak up -- I'm terrible at names. HTH, HAND!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd rather know early if there are snapshots that need cleaning up,
rather than finding out while adding something unrelated. Keeps things
tidy.
I thought of giving Cleanup() this behaviour directly, but suspected a
breaking change like that would not be welcome. So instead I wrote its
wacky sister function. If you see the name, cringe, and think of a
better one, speak up -- I'm terrible at names.
HTH, HAND!