Lwg 20250314 #117
Closed
Lwg 20250314 #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use convert-ref-init-val to convert a U to a T& and initialize value with its address.
GCC 15 correctly notes that 0xCAFEBABE is an unsigned int as an auto.
LEWG had several suggestions for wording.
Use conditional operator instead of if else.
- [X] in p7 what is U? There is something missing - [X] it should be invoke_result_t<F> - [X] the definition of U should be consistent - [X] in p4: we shouldn’t use trailing return types here
Now that "contains a value" is defined for reference optionals.
Update code, also
Add delegation for optional(nullopt_t) constructor.
Tref gets lost.
Fix include/beman/optional/optional.hpp:1368: optioanl ==> optional
Pin one side of value_or ternary to prevent ambiguity in conversions.
Style issue.
Should be "models invocable" not "models invocable<>"
1. missing expos italization of val in contained value defn for optional<T&> 2. In iterator begin() since contained value is now a reference, change the iterator referring to to be to *val 3. Add mandates for transform to require that the result of invoking the supplied function to the contained value can create an object.
P2988R12
Pull Request Test Coverage Report for Build 14273381629Details
💛 - Coveralls |
neatudarius
reviewed
Apr 4, 2025
| @@ -0,0 +1,25 @@ | |||
| // examples/optional_ref.cpp -*-C++-*- | |||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | |||
Member
There was a problem hiding this comment.
Thanks for splitting these examples!
| https://wg21.link/P2988r9 std::optional<T&> | ||
| SD presenting | ||
| [optionalref.iterators] | ||
| TS: p1: “These types” -> “This type” |
Member
There was a problem hiding this comment.
Can you please format them?
L.E. Why do we have duplicated notes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.