Address deprecation of pkgutil.get_loader #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisp3rwind
force-pushed
the
pkgutil_deprecation
branch
from
84627bf to
fb2bdd1
Compare
semohr
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
LGTM 👍
Maybe we want to drop a link to the flask implementation
Took me a moment to find the relevant code.
wisp3rwind
force-pushed
the
pkgutil_deprecation
branch
from
fb2bdd1 to
5814647
Compare
Just rebased on |
semohr
approved these changes
Jun 18, 2025
|
Awesome! Thanks for the initiative here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested, let's see what CI says.
This is on top of #170.
Closes #165