Adding functionality for using "artists" as album level query #5743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure that this is a good fix to the problem, rather than just papering over it. I'm fairly sure that not having Please also see my comment at #5690. |
|
Thank you for the feedback @wisp3rwind! I went more in depth in my response on #5690 but will also mention here that if anyone is to continue working on this issue I'd be happy to try my best to help! :) My "quick fix" here is definitely not addressing the root of the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added the ability to query based on the "artists" field at an album level, along with the existing functionality for "albumartists" field. I have also written 2 tests ensuring that this saves correctly and is correctly query-able.
I have done this by adding "artists" with a string type to the Album class fields.
Addresses Issue #5690, by adding this functionality that user expected, but was previously not supported.
Documentation.I believe documentation changes are not necessarily required for such a small change, beyond updating the Changelog. Correct me if I'm wrong, but I didn't see a place in the documentation where this small change would feel appropriate to mention.