chore: MSRV, 2021 edition, cleanup, clippy #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did some basic cleanup using Clippy and other tools - nothing big :) * Bump edition to 2021 * Add MSRV (I used `cargo msrv` to find it) * Add rust and clippy lint settings to Cargo.toml, including pedantic * format code a bit for readability (mostly suggested by clippy rules) * update `criterion` to v0.6 If you like these, I can also add some common CI and release tooling to automate both validation and the release process of the crate. I use the same setup for many of my projects.
nyurik
commented
Jun 6, 2025
| - name: Run tests | ||
| run: cargo test --verbose | ||
| - name: Markup Link Checker (mlc) | ||
| uses: becheran/[email protected] |
There was a problem hiding this comment.
for some reason this step is listed twice - here and above, but with different versions. Is this by design?
There was a problem hiding this comment.
No. It is stupid. Should be removed
becheran
approved these changes
Jun 9, 2025
| let pixel = imgbuf.get_pixel_mut(prev.0, prev.1); | ||
| *pixel = white; | ||
| prev.0 += 1; | ||
| continue; |
| - name: Run tests | ||
| run: cargo test --verbose | ||
| - name: Markup Link Checker (mlc) | ||
| uses: becheran/[email protected] |
There was a problem hiding this comment.
No. It is stupid. Should be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some basic cleanup using Clippy and other tools - nothing big :)
cargo msrvto find it)criterionto v0.6If you like these, I can also add some common CI and release tooling to automate both validation and the release process of the crate. I use the same setup for many of my projects.