You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Do not show ellipsis if entire text is less than number of elements to show? #12
The text I have to display is highly variable; I can check its length and use this component or a regular div, but it would be so much nicer if this component just "did the right thing" :)
My schedule will not allow me to work on this for at least fifteen days, and by then I will not be working on React / Redux anymore. While I might be able to contribute, I'm afraid you can't count on me to do this.
@stahlmanDesign I updated the setup. Pretty big change but worth it.
On a related note, maybe it would be a good idea to drop state from the component and control it from outside. This would allow us to go stateless style (function) and keep the component even simpler.
Activity
bebraw commentedon Jun 15, 2016
Yeah. That sounds like sane behavior to me. Please PR. 👍
Trevoke commentedon Jun 16, 2016
Hi,
My schedule will not allow me to work on this for at least fifteen days, and by then I will not be working on React / Redux anymore. While I might be able to contribute, I'm afraid you can't count on me to do this.
bebraw commentedon Jun 16, 2016
No problem. I'll hack together something quick for these. Simple enough. 👍
stahlmanDesign commentedon Dec 2, 2016
@bebraw did you ever work on this solution?
bebraw commentedon Dec 2, 2016
@stahlmanDesign Nope, too busy and I forgot the issue. If you want, I can get the project up to date so it's easy to work with.
stahlmanDesign commentedon Dec 2, 2016
That would be great, I'll give it a shot
bebraw commentedon Dec 5, 2016
@stahlmanDesign I updated the setup. Pretty big change but worth it.
On a related note, maybe it would be a good idea to drop state from the component and control it from outside. This would allow us to go stateless style (function) and keep the component even simpler.
bebraw commentedon Dec 5, 2016
I ended up going stateless as that was a simple change to do. Easier code as well now.