Conversation
joshuahannan
left a comment
joshuahannan
left a comment
There was a problem hiding this comment.
Looks really good so far! Thanks for adding this! 😃
| import MetadataViews from "../contracts/MetadataViews.cdc"; | ||
|
|
||
| pub fun main(addr: Address): {UInt64: DappyContract.Template} { | ||
| pub struct DappyDetails { |
There was a problem hiding this comment.
Would it make sense to make defined in the contract instead of in a script?
There was a problem hiding this comment.
It has no use in the contract as the data structure but can define in the contract as well, But I think it will just eat space besides making the system better,
There was a problem hiding this comment.
It doesn't have use in the contract necessarily, but it might be more useful to have it centrally defined instead of having to define it in every script. For cryptodappy, it doesn't really matter because it isn't a production level contract that will actually be in use in the real world, but might be a good practice in smart contracts in general. But if you don't think it should be included in the contract, then I'll defer to you.
There was a problem hiding this comment.
Yeah, I agree with you that it is good to have it in the smart contract for the production-grade system so everyone can use that data structure.
|
@bebner What do you think about this? |
2 participants
No description provided.