Skip to content

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Sep 30, 2025

It's very old and even new versions of pip don't support it.

@nstarman nstarman force-pushed the mnt/py38 branch 4 times, most recently from 7f50a0d to b533e09 Compare September 30, 2025 18:56
@nstarman
Copy link
Contributor Author

@wesselb this PR is ready for review :)

@coveralls
Copy link

coveralls commented Sep 30, 2025

Pull Request Test Coverage Report for Build 18171967968

Details

  • 41 of 41 (100.0%) changed or added relevant lines in 12 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.612%

Totals Coverage Status
Change from base Build 18169713290: 0.0%
Covered Lines: 1284
Relevant Lines: 1289

💛 - Coveralls

@nstarman
Copy link
Contributor Author

2nd commit simplifies a lot of imports!

Copy link
Member

@wesselb wesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is great! Thanks, @nstarman. :) It's about time Plum drops support for 3.8. I've left two comments.

Would it perhaps also be possible to replace e.g. typing.List by list in the code blocks in the docs? This is a bit annoying, so I can also do this myself.

Copy link
Member

@wesselb wesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @nstarman! This is so much cleaner. Merging right away. :)

@wesselb wesselb merged commit bcac404 into beartype:master Oct 3, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants