-
Notifications
You must be signed in to change notification settings - Fork 26
deps: drop py3.8, support py3.9+ #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7f50a0d
to
b533e09
Compare
@wesselb this PR is ready for review :) |
Pull Request Test Coverage Report for Build 18171967968Details
💛 - Coveralls |
2nd commit simplifies a lot of imports! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is great! Thanks, @nstarman. :) It's about time Plum drops support for 3.8. I've left two comments.
Would it perhaps also be possible to replace e.g. typing.List
by list
in the code blocks in the docs? This is a bit annoying, so I can also do this myself.
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, @nstarman! This is so much cleaner. Merging right away. :)
It's very old and even new versions of pip don't support it.