Skip to content

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Jan 6, 2025

@wesselb, this PR adds some type-check only annotations to convert. We can't do more runtime-accessible annotations without running into infinite recursion since convert is called to convert to the return type, unless it isn't annotated / annotated with Any.

@coveralls
Copy link

coveralls commented Jan 6, 2025

Pull Request Test Coverage Report for Build 12640304563

Details

  • 6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 99.609%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plum/promotion.py 6 8 75.0%
Totals Coverage Status
Change from base Build 12033358902: -0.2%
Covered Lines: 1275
Relevant Lines: 1280

💛 - Coveralls

@nstarman
Copy link
Contributor Author

nstarman commented Jan 6, 2025

I'm not sure why coveralls is reporting the TYPE_CHECKING block as unchecked.
In my projects this config woks great.
See https://coverage.readthedocs.io/en/latest/excluding.html#advanced-exclusion

NOTE: When you click on the coveralls, it shows the exclusion is working as expected.

@wesselb
Copy link
Member

wesselb commented Jan 7, 2025

@nstarman, looks fantastic, as always :)! Merging right away. Thank you!!

@wesselb wesselb merged commit bf1d894 into beartype:master Jan 7, 2025
14 checks passed
@nstarman nstarman deleted the typing/promote branch January 7, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants