Assoc only Pathspec Patterns - #178
Open
g-raud wants to merge 25 commits into
Open
Conversation
This will be used to mark regexps as negative or positive.
Note that a string associated with a pathspec is not overriden nor deleted by a negative pathspec; a string given with a negative pathspec is completely ignored. At present this behaviour is fine as when a pathspec preference is overriden by another (negative) preference (ending in "not") the associated string is not used. If this changes the functions assoc and assoc_all may have to be adapted. pred.mli: mention negative pathspec patterns.
Avoid 2 list reversing and add 1 new.
ubase/rx.mli: document the glob patterns.
pred.mli: update the documentation.
Contributor
Author
|
This PR depends on PR #165 (Fixed String Pathspec Patterns). |
This was referenced Mar 21, 2018
g-raud
force-pushed
the
assoc-pathspec-patterns
branch
from
April 3, 2018 00:39
6ffab5a to
05df1cd
Compare
This check is as valid for "name" patterns or Regex as for the others. It is imperfect for glob patterns or regexes though (as was already the case): a pattern always matching a leading slash may not begin by a slash.
The assoc patterns can record an associated string without having to set the preference for the matching paths. So a preference that requires an associated string can be enabled independently someplace else. The associated string is recorded but the pattern is completely ignored for the compiled regex used to match a path in Pred.test. pred.mli: update the documentation.
These are equivalent to the non prefixed patterns and are added only for completeness.
g-raud
force-pushed
the
assoc-pathspec-patterns
branch
from
April 13, 2018 11:41
05df1cd to
6adc57e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A "pattern"
assoc <PATTERN>to record the associated string without setting the preference. Example:The patterns
add <PATTERN>equivalent to<PATTERN>are also added for completeness but left undocumented.