32870: legal-api - Use additional currency text if present#4353
Merged
loneil merged 1 commit intobcgov:mainfrom May 4, 2026
Merged
32870: legal-api - Use additional currency text if present#4353loneil merged 1 commit intobcgov:mainfrom
loneil merged 1 commit intobcgov:mainfrom
Conversation
Signed-off-by: Lucas <lucasoneil@gmail.com>
loneil
changed the title
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the share structure report template to display the “other currency” free-text value (when provided) instead of the literal currency code, improving readability for legacy/grandfathered share classes that use currency='OTHER'.
Changes:
- In the share class row, show
currencyAdditionalwhencurrencyis OTHER (fallback to “Other”). - In the share series row (which uses share class par value/currency), apply the same display behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kialj876
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#32870
Description of changes:
Just a small tweak to display other currency text if present.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).