feat(search): search as you type - #876
Merged
Merged
Conversation
Document search, project list, news and project notifications refetch 300 ms after typing stops, from two characters. Previous rows stay on screen between keystrokes and superseded requests are aborted.
danieltruong
requested review from
Ckoelewyn,
tolkamps1 and
tom0827
as code owners
September 11, 2026 00:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Document search, project list, news and project notifications refetch 300 ms after typing stops, once the keyword has two characters or is cleared. Previous rows stay on screen between keystrokes and a superseded request is aborted. The Search button and Enter still work. The result count is announced through
aria-live="polite".Side effect: the project documents tab shares the filter component and gains the same two-character minimum.
Server side: fuzzy and prefix matching on the last token come from DEMI (digitalspace/eagle-demi#381). Until that lands on test, a partial word can return no rows on the project list.
Tests
yarn test851 pass. Unit specs for debounce, minimum length, abort on supersede, previous rows kept, URL restore; two Playwright specs type without clicking. Request baseline unchanged: no default page-load request changed.