34153 changes based on the ux review - #523
Conversation
|
/gcbrun |
|
Temporary Url for review: https://business-registry-home-dev--pr-523-966isd4r.web.app |
|
Temporary Url for review: https://business-corps-dev--pr-523-g1glnvmf.web.app |
|
Temporary Url for review: https://business-people-dev--pr-523-ah1o89ml.web.app |
There was a problem hiding this comment.
Pull request overview
This PR updates the Effective Date input experience to address UX/accessibility feedback (labeling, icon behavior/styling, calendar focus treatment, and clearer validation guidance).
Changes:
- Improves Effective Date validation hinting and adds screen-reader announcements for errors.
- Updates the Date input’s calendar/clear action buttons (color, focus styles) and keyboard interactions.
- Adds a changeset to publish the update as a minor version bump.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/layers/base/i18n/locales/en-CA.ts | Adds a new validation.invalidDate translation string. |
| packages/layers/base/app/components/Form/PartyDetails.vue | Removes a separator after the effective-date section. |
| packages/layers/base/app/components/Form/EffectiveDate/index.vue | Updates validation hint text behavior, passes required through, and adds live region announcements. |
| packages/layers/base/app/components/Date/index.vue | Adjusts Date input keyboard/accessibility behavior and updates action button + calendar focus styling. |
| .changeset/chatty-boxes-float.md | Declares a minor release for the base package. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
/gcbrun |
|
Temporary Url for review: https://business-registry-home-dev--pr-523-966isd4r.web.app |
|
Temporary Url for review: https://business-people-dev--pr-523-ah1o89ml.web.app |
|
Temporary Url for review: https://business-corps-dev--pr-523-g1glnvmf.web.app |
|
/gcbrun |
|
Temporary Url for review: https://business-registry-home-dev--pr-523-966isd4r.web.app |
|
Temporary Url for review: https://business-corps-dev--pr-523-g1glnvmf.web.app |
|
Temporary Url for review: https://business-people-dev--pr-523-ah1o89ml.web.app |
…cted when the component is used in Party Details.
|
/gcbrun |
|
Temporary Url for review: https://business-people-dev--pr-523-ah1o89ml.web.app |
|
Temporary Url for review: https://business-registry-home-dev--pr-523-966isd4r.web.app |
|
Temporary Url for review: https://business-corps-dev--pr-523-g1glnvmf.web.app |
|
/gcbrun |
|
Temporary Url for review: https://business-registry-home-dev--pr-523-966isd4r.web.app |
|
Temporary Url for review: https://business-corps-dev--pr-523-g1glnvmf.web.app |
|
Temporary Url for review: https://business-people-dev--pr-523-ah1o89ml.web.app |
Issue #: /bcgov/entity###
bcgov/entity#34153
Description of changes:
#1669BB).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-ui license (BSD 3-Clause).