Merge feature-business-layer branch into main - #343

Closed

deetz99 wants to merge 83 commits into

mainfrom

feature-business-layer

deetz99 commented Dec 16, 2025

Collaborator

Issue #: bcgov/entity#31285

Description of changes:

title

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

deetz99 and others added 30 commits

August 26, 2025 11:44


          init monorepo (#202)

dd5ea78


          init changesets (#204)

c2a4e61

* init changesets

* add changeset config, change business layer to be under connect org for now


          Add Connect layers to business layer (#206)

535bd78

* minimal change to base and person roles to get new layers working

* add changeset


          chore: update versions (#207)

026a338

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          Root level eslint (#208)

a5ba089

* add eslint to root of workspace

* remove eslint from nuxt config in person roles


          Shared test configs (#210)

a5dbbea

* create shared pw and vitest configs

* add changeset

* fix

* cleanup

* fix lint ignore


          chore: update versions (#211)

4f522f7

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          Base layer ci (#212)

a484bba

* init base layer CI

* update env.example

* fix

* add changeset

* add paths filter to changesets workflow


          chore: update versions (#213)

426671f

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          Refactor officers (#216)

07f8251

* remove old checkbox group components

* use address component from forms layer

* use address complete from forms layer

* remove unused utils/tests

* update address interface

* switch formfield input elements for connect

* switch to connect form structure els

* update css to use new vars

* switch to formlayout

* switch to button control from forms

* switch to pay widget/store from pay layer

* remove unneeded zod schemas

* cleanup app config

* update legal api definition

* update vaults env names

* add changeset


          chore: update versions (#219)

b6d6019

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          Refactor person roles (#220)

c0a0515

* move business types, plugins, composables, tests, etc to business layer

* fix deps

* move business tombstone and filing layout to layer

* cleanup i18n

* update padding on layout

* cleanup error modal

* only fetch fees if business defined

* update error modal

* refactor modals

* add changeset

* fix lint

* revert accidental change in prta directory


          chore: update versions (#222)

a4b8522

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          test new workflow (#223)

e170caa


          Update person roles ci (#224)

c037108

* update

* update


          Business Layer/Officers - Refactor tombstone component (#227)

ddf1216

* update layer versions

* refactor to use tombstone from connect base layer

* move auth info fetch to business api composable, define plugin types as they arent being inferred correctly

* add changeset

* add test for filing tombstone composable

* remove auth user state in e2e test

* fix test


          chore: update versions (#229)

ca7ea62

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          Person roles e2e tests (#230)

248a325

* form validation e2e tests

* add officer tests

* edit person tests

* refactor test helpers for form validation and add officer flows

* refactor edit officer flow

* task guard tests

* task guard tests

* draft filing tests

* page init errors tests

* remove wait for network idle

* update person-roles ci

* update tests to pass for CI

* fix for firefox

* fix flaky tests, exclude mobile

* remove commented line in pw config

* fix env name, add changesets

* bump version

* switch to config.playwright check instead of config.ci in auth middleware

* fix country select handling

* minor fix

* increase timeout in pw setup

* fix unit tests

* fix lint


          chore: update versions (#232)

b085d91

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          Cleanup middleware (#235)

92fcc09

* add changeset

* use new auth page, cleanup playwright middleware

* fix base layer e2e test

* fix lint


          chore: update versions (#236)

c149cb6

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          Officers - Refactor modals (#237)

44eaf88

* refactor officer error modals

* update base layer deps


          chore: update versions (#240)

eed8ca5

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          30534 - officers add ff check (#241)

eeb554b

* add ff check on officers init

* update vault env values

* ignore ff check if e2e tests

* bump version

* try updating node version to fix unit tests in ci


          29341 business layer docs (#242)

87dfb3a

* fix vitest coverage file path

* update base layer readme, rename/organize utils, update/add tests

* add changeset for base

* add changesets usage docs

* update officers with new util name

* bump person roles version

* start docs for business layer

* update head/breadcrumb text


          chore: update versions (#243)

ea0ee7e

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          30534 - officers updates (#244)

370c175

* remove save button, update tests

* update base layer with business edit config val, remove officer specific i18n labels, add company info page i18n label

* update user redirect after save/submit/cancel/modal actions, either to business dashboard or edit ui

* set correct default breadcrumb and header text, bcreg instead of connect

* remove unnecessary pending task check on init, update/fix e2e tests

* e2e test update

* fix address fill in e2e

* remove comment


          chore: update versions (#245)

0311c53

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          update cd and build command (#248)

465e7ea


          Business layer - filing ledger code (#273)

6bed0a7

* Business layer - filing ledger code

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* Update bootstrap flow

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* lint fix and fixes

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* added in tests

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* Added in alerts component, some updates to ledger

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* Updated for PR comments

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* fix unit test

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* Pr comment updates

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* removed unused store function

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* removed unused store function

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* fix ci and changeset

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

---------

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

github-actions Bot and others added 14 commits

December 5, 2025 10:46


          chore: update versions (#324)

b9763cf

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          Officers - Set Mailing address required, fix ID not being included on…

21d1044

… form submit (#325)

* add id property to officer form schema

* update version


          fix duplicate/incorrect modal displaying on filing init errors (#327)

07320c4

* fix duplicate/incorrect modal displaying on filing init errors

* simplify errors

* remove .only from unit test

* e2e test update

* test update

* remove unecessary if statements

* cleanup parties


          filter unchanged officers from filing payload (#329)

289e584


          chore: update versions (#330)

d714c18

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>


          text/validation update (#333)

df88a8b


          sync latest from main (#337)

1763b2d


          Setup new BRH (registry-home) app (#331)

c543b8e

* init registry home app

* add root devops.env for registry home

* add CICD

* update app name in CD

* update site name in firebase.json


          finalize receiver submission (#332)

439e937

* Initial code

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* Updates

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* Updated tests

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* Update filing watcher

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* Finish updating tests

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* updated changeset

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

* Update to liquidators flow

Signed-off-by: Kial Jinnah <kialj876@gmail.com>

---------

Signed-off-by: Kial Jinnah <kialj876@gmail.com>


          DOD: init app (#336)

c7babb4

* init DOD app

* add missing app config and test setup files


          Small update for ammend receiver (#340)

e7480f1

Signed-off-by: Kial Jinnah <kialj876@gmail.com>


          sync feature with latest from main (#342)

956b4fc


          31372 31370 - dod framework components (#341)

de467bd

* checkpoint

* dod store

* checkpoint

* fix i18n for page description

* unit test schemas

* add missing i18n

* init e2e setup - needs filing name to complete permissions and isAllowed checks

* fix lint

* add dissoultion types

* remove unnecessary nested form for addToLedger component

* dissolution enums, test fixes, breadcrumb value

* remove unnecessary mocks, add fee mock, add submit test

* use DissolutionType enum for filing sub types enum

* create common api calls mock, add to dissolution

* add new test util to receivers and liquidators, cleanup old code

* revert pw config change

* fix unit test

* revert pnpm lock

* add prepare step after pnpm install in e2e ci

* add postinstall to pnpm test command

* fix unit test

* fix unit test

* fix unit test


          chore: update versions (#339)

814eea2

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

deetz99 requested a review from cameron-eyds

December 16, 2025 23:42

deetz99 self-assigned this

deetz99 requested review from BrandonSharratt, JazzarKarim, TVWerdal, hfekete, kialj876, pwei1018, severinbeauvais and thorwolpert as code owners

December 16, 2025 23:42

github-advanced-security AI found potential problems

View reviewed changes

.github/workflows/dissolution-cd.yaml

Comment on lines +23 to +32

+                  uses: bcgov/bcregistry-sre/.github/workflows/frontend-cd.yaml@main
+                  with:
+                    target: ${{ inputs.target }}
+                    app_name: "dissolution"
+                    working_directory: "."
+                    node_version: 24
+                    pnpm_version: 10.0.0
+                  secrets:
+                    WORKLOAD_IDENTIFY_POOLS_PROVIDER: ${{ secrets.WORKLOAD_IDENTIFY_POOLS_PROVIDER }}
+                    GCP_SERVICE_ACCOUNT: ${{ secrets.GCP_SERVICE_ACCOUNT }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

.github/workflows/dissolution-ci.yaml

Comment on lines +16 to +24

+                  uses: pwei1018/bcregistry-sre/.github/workflows/frontend-ci.yaml@rollback-op
+                  with:
+                    app_name: "dissolution"
+                    working_directory: "./web/dissolution"
+                    codecov_flag: "dissolution"
+                    node_version: 24
+                    pnpm_version: 10.0.0
+                e2e-tests:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

.github/workflows/dissolution-ci.yaml

Comment on lines +25 to +68

+                  runs-on: ubuntu-latest
+                  strategy:
+                    fail-fast: false
+                    matrix:
+                      project: ["dissolution"]
+                      shardIndex: [1, 2, 3, 4 ]
+                      shardTotal: [4]
+                  defaults:
+                    run:
+                      working-directory: ./web/${{ matrix.project }}
+                  env:
+                    CI: true
+                  container:
+                    image: mcr.microsoft.com/playwright:v1.54.0-noble
+                  steps:
+                  - uses: actions/checkout@v4
+                  - uses: pnpm/action-setup@v4
+                    with:
+                      version: 10
+                      run_install: false
+                  - uses: actions/setup-node@v4
+                    with:
+                      node-version: 24
+                      cache: 'pnpm'
+                  - name: Install dependencies
+                    run: pnpm install
+                  - name: Generate Types
+                    run: pnpm postinstall
+                  - name: Install Playwright browsers
+                    run: npx playwright install --with-deps
+                  - name: Set basic env
+                    run: |
+                      cp .env.example .env
+                  - name: Run Playwright tests
+                    run: HOME=/root pnpm test:e2e --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
+                  - name: Upload blob report to GitHub Actions Artifacts
+                    if: ${{ !cancelled() }}
+                    uses: actions/upload-artifact@v4
+                    with:
+                      name: blob-report-${{ matrix.shardIndex }}
+                      path: web/${{ matrix.project }}/blob-report
+                      retention-days: 1
+                merge-reports:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

.github/workflows/dissolution-ci.yaml

Comment on lines +69 to +99

+                  if: ${{ !cancelled() }}
+                  needs: [e2e-tests]
+                  strategy:
+                    fail-fast: false
+                    matrix:
+                      project: ["dissolution"]
+                  defaults:
+                    run:
+                      working-directory: ./web/${{ matrix.project }}
+                  runs-on: ubuntu-latest
+                  steps:
+                  - uses: actions/checkout@v4
+                  - uses: actions/setup-node@v4
+                    with:
+                      node-version: lts/*
+                  - name: Download blob reports from GitHub Actions Artifacts
+                    uses: actions/download-artifact@v4
+                    with:
+                      path: web/${{ matrix.project }}/all-blob-reports
+                      pattern: blob-report-*
+                      merge-multiple: true
+                  - name: Merge into HTML Report
+                    run: npx playwright merge-reports --reporter html ./all-blob-reports
+                  - name: Upload HTML report
+                    uses: actions/upload-artifact@v4
+                    with:
+                      name: html-report--attempt-${{ github.run_attempt }}
+                      path: web/${{ matrix.project }}/playwright-report
+                      retention-days: 2    

                
                    No newline at end of file

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

.github/workflows/layers-base-ci.yaml

Comment on lines +15 to +42

+                  runs-on: ubuntu-latest
+                  strategy:
+                    fail-fast: false
+                    matrix:
+                      project: ["base"]
+                      job: ['lint', 'build', 'test:unit'] # ['lint', 'typecheck', 'build', 'test:unit'] # TODO: fix typecheck
+                  defaults:
+                    run:
+                      working-directory: ./packages/layers/${{ matrix.project }}
+                  steps:
+                  - uses: actions/checkout@v4
+                  - uses: pnpm/action-setup@v4
+                    with:
+                      version: 10
+                      run_install: false
+                  - uses: actions/setup-node@v4
+                    with:
+                      node-version: 24
+                      cache: 'pnpm'
+                  - name: Install dependencies
+                    run: pnpm install
+                  - name: Set basic env
+                    run: |
+                      cp .env.example .env
+                  - name: ${{ matrix.job }}
+                    run: pnpm ${{ matrix.job }}
+                e2e-tests:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

.github/workflows/person-roles-ci.yaml

Comment on lines +67 to +97

+                merge-reports:
+                  if: ${{ !cancelled() }}
+                  needs: [e2e-tests]
+                  strategy:
+                    fail-fast: false
+                    matrix:
+                      project: ["person-roles"]
+                  defaults:
+                    run:
+                      working-directory: ./web/${{ matrix.project }}
+                  runs-on: ubuntu-latest
+                  steps:
+                  - uses: actions/checkout@v4
+                  - uses: actions/setup-node@v4
+                    with:
+                      node-version: lts/*
+                  - name: Download blob reports from GitHub Actions Artifacts
+                    uses: actions/download-artifact@v4
+                    with:
+                      path: web/${{ matrix.project }}/all-blob-reports
+                      pattern: blob-report-*
+                      merge-multiple: true
+                  - name: Merge into HTML Report
+                    run: npx playwright merge-reports --reporter html ./all-blob-reports
+                  - name: Upload HTML report
+                    uses: actions/upload-artifact@v4
+                    with:
+                      name: html-report--attempt-${{ github.run_attempt }}
+                      path: web/${{ matrix.project }}/playwright-report

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

.github/workflows/registry-home-cd.yaml

Comment on lines +23 to +32

+                  uses: bcgov/bcregistry-sre/.github/workflows/frontend-cd.yaml@main
+                  with:
+                    target: ${{ inputs.target }}
+                    app_name: "business-registry-home"
+                    working_directory: "."
+                    node_version: 24
+                    pnpm_version: 10.0.0
+                  secrets:
+                    WORKLOAD_IDENTIFY_POOLS_PROVIDER: ${{ secrets.WORKLOAD_IDENTIFY_POOLS_PROVIDER }}
+                    GCP_SERVICE_ACCOUNT: ${{ secrets.GCP_SERVICE_ACCOUNT }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

.github/workflows/registry-home-ci.yaml

Comment on lines +16 to +24

+                  uses: pwei1018/bcregistry-sre/.github/workflows/frontend-ci.yaml@rollback-op
+                  with:
+                    app_name: "registry-home"
+                    working_directory: "./web/registry-home"
+                    codecov_flag: "registryhome"
+                    node_version: 24
+                    pnpm_version: 10.0.0
+                e2e-tests:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

.github/workflows/registry-home-ci.yaml

Comment on lines +25 to +66

+                  runs-on: ubuntu-latest
+                  strategy:
+                    fail-fast: false
+                    matrix:
+                      project: ["registry-home"]
+                      shardIndex: [1, 2, 3, 4 ]
+                      shardTotal: [4]
+                  defaults:
+                    run:
+                      working-directory: ./web/${{ matrix.project }}
+                  env:
+                    CI: true
+                  container:
+                    image: mcr.microsoft.com/playwright:v1.54.0-noble
+                  steps:
+                  - uses: actions/checkout@v4
+                  - uses: pnpm/action-setup@v4
+                    with:
+                      version: 10
+                      run_install: false
+                  - uses: actions/setup-node@v4
+                    with:
+                      node-version: 24
+                      cache: 'pnpm'
+                  - name: Install dependencies
+                    run: pnpm install
+                  - name: Install Playwright browsers
+                    run: npx playwright install --with-deps
+                  - name: Set basic env
+                    run: |
+                      cp .env.example .env
+                  - name: Run Playwright tests
+                    run: HOME=/root pnpm test:e2e --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
+                  - name: Upload blob report to GitHub Actions Artifacts
+                    if: ${{ !cancelled() }}
+                    uses: actions/upload-artifact@v4
+                    with:
+                      name: blob-report-${{ matrix.shardIndex }}
+                      path: web/${{ matrix.project }}/blob-report
+                      retention-days: 1
+                merge-reports:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

.github/workflows/registry-home-ci.yaml

Comment on lines +67 to +97

+                  if: ${{ !cancelled() }}
+                  needs: [e2e-tests]
+                  strategy:
+                    fail-fast: false
+                    matrix:
+                      project: ["registry-home"]
+                  defaults:
+                    run:
+                      working-directory: ./web/${{ matrix.project }}
+                  runs-on: ubuntu-latest
+                  steps:
+                  - uses: actions/checkout@v4
+                  - uses: actions/setup-node@v4
+                    with:
+                      node-version: lts/*
+                  - name: Download blob reports from GitHub Actions Artifacts
+                    uses: actions/download-artifact@v4
+                    with:
+                      path: web/${{ matrix.project }}/all-blob-reports
+                      pattern: blob-report-*
+                      merge-multiple: true
+                  - name: Merge into HTML Report
+                    run: npx playwright merge-reports --reporter html ./all-blob-reports
+                  - name: Upload HTML report
+                    uses: actions/upload-artifact@v4
+                    with:
+                      name: html-report--attempt-${{ github.run_attempt }}
+                      path: web/${{ matrix.project }}/playwright-report
+                      retention-days: 2    

                
                    No newline at end of file

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

cameron-eyds approved these changes

View reviewed changes

severinbeauvais commented Dec 17, 2025

Contributor

I see a code conflict and I'd like to see all the checks passing if possible.

thorwolpert approved these changes

View reviewed changes

thorwolpert left a comment

Collaborator

Nice, maybe add an issue with followup for the permission settings.

deetz99 commented Dec 17, 2025

Collaborator Author

@cameron-eyds @severinbeauvais @thorwolpert

Sorry folks I goofed this PR, please use #344.

Closing.

deetz99 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

+1 more reviewer

Labels

None yet