Skip to content

Certify component tweaks#307

Merged
kialj876 merged 5 commits intobcgov:mainfrom
kialj876:32805-certify-component-tweaks
Apr 28, 2026
Merged

Certify component tweaks#307
kialj876 merged 5 commits intobcgov:mainfrom
kialj876:32805-certify-component-tweaks

Conversation

@kialj876
Copy link
Copy Markdown
Collaborator

@kialj876 kialj876 commented Apr 28, 2026

Issue #: /bcgov/entity#32805

Description of changes:

  • design tweaks
  • added slot so that we can replace the checkbox text easily for edge cases without needing to update this component

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

examples:

no legal name confirm auth
Screenshot 2026-04-28 at 3 29 27 PM

no legal name certify new
Screenshot 2026-04-28 at 3 28 46 PM

legal name
Screenshot 2026-04-28 at 3 29 07 PM

Signed-off-by: Kial Jinnah <kialj876@gmail.com>
@kialj876
Copy link
Copy Markdown
Collaborator Author

NOTE: When building and running storybook it auto changed all the storybook files.
I did update the base.css so that it displays the error color when setting the error-text class in certify so that may be why. Let me know if you want me to revert the storybook file changes

Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
@kialj876 kialj876 requested review from loneil and meawong April 28, 2026 19:12
@kialj876
Copy link
Copy Markdown
Collaborator Author

Other notes:

  • updated package-lock for node 24
  • updated CI to run on node 24 instead of 20
  • single failing test is a known intermittent error

Copy link
Copy Markdown
Collaborator

@meawong meawong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing test is existing on previous PRs and not broken by your changes. LGTM - thanks for making these changes!

Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
@kialj876 kialj876 merged commit 69247eb into bcgov:main Apr 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants