fix: set font-display: swap - #24
Open
roedoejet wants to merge 1 commit into
Open
Conversation
ensures text is visible even if font is not yet loaded
Collaborator
|
Thanks very much for the PR @roedoejet! I will take this change request to our team for discussion and I'll do some testing on it to see what the implications might be (especially contrasting how this might affect content heavy web pages vs dense web application layouts). On a related note, previously, we have had folks request things like System Font Stack, either instead of or as a fallback for BC Sans. This might be a thing where we have to work in concert with the B.C. Design System to give different guidance depending on the app context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures text is visible even if font is not yet loaded.
This might produce some layout shifts, but ultimately I think this is more accessible particularly on slower networks.
Originally from #9