fix(ui): 1546 improved email validation#1605
Open
JazzarKarim wants to merge 2 commits intobcgov:mainfrom
Open
Conversation
Collaborator
|
Temporary Url for review: https://strr-platform-dev--pr-1605-9vwirw0c.web.app |
dimak1
reviewed
May 4, 2026
|
Collaborator
|
Temporary Url for review: https://strr-hosts-dev--pr-1605-x5ceta8x.web.app |
dimak1
approved these changes
May 6, 2026
Collaborator
|
@JazzarKarim as Jimmy said, the tests are failing because of base changes... |
Collaborator
Author
Yes, correct. After merging, any new PRs and tests should pass as they'll pull from the new changes. Is that fine? I could split this into 2 PRs but I figured that's OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Description of changes:
Improved email validation to better validate emails like foo@ba$.com for example
Unit tests for platforms pass:
It's just since it's in nuxt config, it still points to base layer which doesn't have the latest changes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License