This repository was archived by the owner on Nov 27, 2018. It is now read-only.
bindToController not working with latest angular 1.6.4#56
Open
theoomoregbee wants to merge 2 commits intobcabanes:masterfrom
theoomoregbee:patch-1
Open
bindToController not working with latest angular 1.6.4#56theoomoregbee wants to merge 2 commits intobcabanes:masterfrom theoomoregbee:patch-1
theoomoregbee wants to merge 2 commits intobcabanes:masterfrom
theoomoregbee:patch-1
Conversation
so reverted to scope and still use constructor's children to pass the variables from scope to self
Author
|
#54 to help handle this issue |
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 78.58% 78.77% +0.18%
==========================================
Files 7 7
Lines 453 457 +4
==========================================
+ Hits 356 360 +4
Misses 97 97
Continue to review full report at Codecov.
|
|
this library seems to not be working for angular 1.6.x, when are you planning on supporting that version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so reverted to scope and still use constructor's children to pass the variables from scope to self