Conversation
elvinasv
reviewed
Mar 31, 2026
src/app/components/Account/AccountPromotionalBanner/index.styles.tsx
Outdated
Show resolved
Hide resolved
src/app/components/Account/AccountPromotionalBanner/index.styles.tsx
Outdated
Show resolved
Hide resolved
src/app/components/Account/AccountPromotionalBanner/index.styles.tsx
Outdated
Show resolved
Hide resolved
src/app/components/Account/AccountPromotionalBanner/index.styles.tsx
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the World Service Account promotional banner and shared account icon to match updated UX styling/markup and adjust the PromotionalBanner layout for responsive spacing.
Changes:
- Tweaks
PromotionalBannercontent padding so bottom padding increases atGROUP_1_MIN_WIDTH. - Updates
AccountPromotionalBannerCTA markup to replace chevrons with anAccountIconfor sign-in and remove the register chevron. - Updates CTA styling (sizes/padding/visited styles) and refreshes the
AccountIconSVG path/viewBox.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/app/components/PromotionalBanner/index.styles.ts |
Adjusts responsive bottom padding at GROUP_1_MIN_WIDTH. |
src/app/components/icons/index.tsx |
Updates AccountIcon SVG sizing and path to new design. |
src/app/components/Account/AccountPromotionalBanner/index.tsx |
Updates CTA markup to use AccountIcon and removes chevrons. |
src/app/components/Account/AccountPromotionalBanner/index.styles.tsx |
Updates CTA and icon styling (fixed sizing, visited color overrides, underline styling). |
src/app/components/Account/AccountPromotionalBanner/index.styles.tsx
Outdated
Show resolved
Hide resolved
src/app/components/Account/AccountPromotionalBanner/index.styles.tsx
Outdated
Show resolved
Hide resolved
…EUTRAL_LIGHT to theme config
…igh contrast support
…-to-production-ready-version
…n-ready-version' of https://github.com/bbc/simorgh into WS-2236-upgrade-account-promotional-banner-to-production-ready-version
elvinasv
reviewed
Mar 31, 2026
src/app/components/Account/AccountPromotionalBanner/index.styles.tsx
Outdated
Show resolved
Hide resolved
…-to-production-ready-version
…-to-production-ready-version
elvinasv
approved these changes
Mar 31, 2026
SantaZena
approved these changes
Apr 1, 2026
HarveyPeachey
approved these changes
Apr 1, 2026
…-to-production-ready-version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: https://bbc.atlassian.net/browse/WS-2236
Summary
Account Promotional Banner component is now aligned with UX and accessibility standards and is safe to be released to production for Hindi locale.
Code changes
AccountPromotionalBannerCTA styling: fixed sizes/padding, white visited text, register as underlined white link, added account icon styles.AccountPromotionalBannermarkup: replaced chevrons with AccountIcon for sign-in and removed chevron from register.PromotionalBannerresponsive spacing: bottom padding becomes TRIPLE at GROUP_1_MIN_WIDTH.AccountIconSVG: new viewBox/size and new path to match updated design.Testing
Useful Links