Skip to content

[WS-2236] Upgrade Account Promotional Banner to Production‑Ready Version#13850

Merged
LukasFrm merged 17 commits intolatestfrom
WS-2236-upgrade-account-promotional-banner-to-production-ready-version
Apr 1, 2026
Merged

[WS-2236] Upgrade Account Promotional Banner to Production‑Ready Version#13850
LukasFrm merged 17 commits intolatestfrom
WS-2236-upgrade-account-promotional-banner-to-production-ready-version

Conversation

@LukasFrm
Copy link
Copy Markdown
Contributor

@LukasFrm LukasFrm commented Mar 30, 2026

Resolves JIRA: https://bbc.atlassian.net/browse/WS-2236

Summary

Account Promotional Banner component is now aligned with UX and accessibility standards and is safe to be released to production for Hindi locale.

image

Code changes

  • Updated AccountPromotionalBanner CTA styling: fixed sizes/padding, white visited text, register as underlined white link, added account icon styles.
  • Updated AccountPromotionalBanner markup: replaced chevrons with AccountIcon for sign-in and removed chevron from register.
  • Updated PromotionalBanner responsive spacing: bottom padding becomes TRIPLE at GROUP_1_MIN_WIDTH.
  • Updated AccountIcon SVG: new viewBox/size and new path to match updated design.

Testing

  1. List the steps required to test this PR.

Useful Links

Copy link
Copy Markdown
Member

@elvinasv elvinasv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elvinasv elvinasv marked this pull request as ready for review March 31, 2026 07:37
Copilot AI review requested due to automatic review settings March 31, 2026 07:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the World Service Account promotional banner and shared account icon to match updated UX styling/markup and adjust the PromotionalBanner layout for responsive spacing.

Changes:

  • Tweaks PromotionalBanner content padding so bottom padding increases at GROUP_1_MIN_WIDTH.
  • Updates AccountPromotionalBanner CTA markup to replace chevrons with an AccountIcon for sign-in and remove the register chevron.
  • Updates CTA styling (sizes/padding/visited styles) and refreshes the AccountIcon SVG path/viewBox.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/app/components/PromotionalBanner/index.styles.ts Adjusts responsive bottom padding at GROUP_1_MIN_WIDTH.
src/app/components/icons/index.tsx Updates AccountIcon SVG sizing and path to new design.
src/app/components/Account/AccountPromotionalBanner/index.tsx Updates CTA markup to use AccountIcon and removes chevrons.
src/app/components/Account/AccountPromotionalBanner/index.styles.tsx Updates CTA and icon styling (fixed sizing, visited color overrides, underline styling).

@LukasFrm LukasFrm requested a review from elvinasv March 31, 2026 14:41
@LukasFrm LukasFrm merged commit 5bb906f into latest Apr 1, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants