Skip to content

experiment page view debuggin #13667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
HarveyPeachey wants to merge 1 commit into
base: latest
Choose a base branch
from
Draft

experiment page view debuggin #13667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/app/components/OptimizelyPageMetrics/experimentsForPageMetrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ type ExperimentsForPageTypeMetrics = {
activeExperiments: string[];
}[];

const experimentsForPageMetrics: ExperimentsForPageTypeMetrics = [];
const experimentsForPageMetrics: ExperimentsForPageTypeMetrics = [
{ pageType: 'article', activeExperiments: ['general_event_bleed_test_1'] },
];

export default experimentsForPageMetrics;
1 change: 1 addition & 0 deletions src/app/components/OptimizelyPageMetrics/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const OptimizelyPageMetrics = ({
useEffect(() => {
if (optimizelyExperimentsEnabled) {
optimizely?.onReady().then(() => {
console.log('Optimizely Page Metrics');
const decisions = optimizely.decideAll([
OptimizelyDecideOption.DISABLE_DECISION_EVENT,
]);
Expand Down
1 change: 1 addition & 0 deletions src/app/hooks/useOptimizelyVariation/useClientSide/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export default ({ experimentName, overrideAttributes = {} }: Props) => {

useEffect(() => {
if (isClientReady && !didTimeout) {
console.log('Optimizely useOptimizelyVariation - Client Side');
setVariation(decision.variationKey);
}
}, [isClientReady, decision.variationKey, didTimeout]);
Expand Down
8 changes: 8 additions & 0 deletions src/app/pages/ArticlePage/ArticlePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ import ArticleLinksBlock from '#app/components/ArticleLinksBlock';
import Recommendations from '#app/components/Recommendations';
import ReadTimeArticle from '#app/components/ReadTime';
import PWAPromotionalBanner from '#app/components/PWAPromotionalBanner';
import useOptimizelyVariation, {
ExperimentType,
} from '#app/hooks/useOptimizelyVariation';
import ElectionBanner from './ElectionBanner';
import ImageWithCaption from '../../components/ImageWithCaption';
import AdContainer from '../../components/Ad';
Expand Down Expand Up @@ -192,6 +195,11 @@ const ArticlePage = ({ pageData }: { pageData: Article }) => {
);
const { enabled: isTopBarOJsEnabled } = useToggle('topBarOJs');

useOptimizelyVariation({
experimentName: 'general_event_bleed_test_1',
experimentType: ExperimentType.CLIENT_SIDE,
});

const {
palette: { GREY_2 },
} = useTheme();
Expand Down