Collect toolchain files by action in one pass - #872
Open
dzbarsky wants to merge 1 commit into
Open
Conversation
Walk each ArgsListInfo.by_action once and append its files only for configured tool actions. Preserve each tool’s runfiles and the resulting per-action depsets. Tested: bazel test //tests/rule_based_toolchain/toolchain_config:test_suite
lilygorsheneva
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Construct
ToolchainConfigInfo.filesby initializing each configured action with its tool runfiles, then walkingArgsListInfo.by_actionfor the toolchain args and each feature once. This avoids repeated action lookups while preserving the per-action file sets.Tested:
bazel test //tests/rule_based_toolchain/toolchain_config:test_suite(12 tests passed).