Exclude assemble actions from include/random-seed cc_args - #864
Open
dcavalei wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The updated action scope also drops objc_compile, which appears to go beyond the stated intent and should be reconciled (code vs. PR description).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Scopes the random_seed toolchain argument so -frandom-seed={output_file} is no longer applied to assembly actions, avoiding Clang -Wunused-command-line-argument warnings when assembling .s files (related to #698).
Changes:
- Narrow
random_seedargument application fromcompile_actionsto just C/C++ compile action sets.
File summaries
| File | Description |
|---|---|
| cc/toolchains/args/random_seed/BUILD | Narrows the random_seed cc_args action scope to avoid passing -frandom-seed to assembly actions. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+14
to
+17
| actions = [ | ||
| "//cc/toolchains/actions:c_compile_actions", | ||
| "//cc/toolchains/actions:cpp_compile_actions", | ||
| ], |
-frandom-seed has no effect on assembly and causes Clang to warn with -Wunused-command-line-argument when assembling .s files. Objective-C compilation is kept in scope since it goes through the same deterministic-hash codegen as C/C++. Related to bazelbuild#698
dcavalei
force-pushed
the
fix/random-seed-assembly-actions
branch
from
September 2, 2026 14:27
e17c0a3 to
6883ab2
Compare
dcavalei
marked this pull request as draft
September 2, 2026 15:00
Author
|
I've found a few more things that can be fixed, so I am converting this back to draft. I will bundle a few fixes first. |
assemble compiles already-preprocessed assembly, so include-path flags are unused there. Relates to bazelbuild#698
dcavalei
force-pushed
the
fix/random-seed-assembly-actions
branch
from
September 2, 2026 16:38
353fa32 to
24eafec
Compare
dcavalei
changed the title
dcavalei
marked this pull request as ready for review
September 3, 2026 08:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-frandom-seed has no effect on assembly and causes Clang to warn with -Wunused-command-line-argument when assembling .s files.
Related to #698