Enforce SHA-256 for all external downloads #4518
Open
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitigates supply-chain RCE (Google VRP issue 462506853). Any genrule that downloads external tarballs now **must** provide SHA-256; otherwise the build fails.
tgovacul
changed the title
Author
SummaryIntroduces //tools:download.bzl with secure_download() macro. Testingbazel test //... passes; intentional hash mismatch fails as expected. |
Author
|
CLA already signed – see https://cla.developers.google.com/clas/signed (Luca Vogt) |
Collaborator
|
Could you explain this a bit? It doesn't really make any sense.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates supply-chain RCE (Google VRP issue 462506853). Any genrule that downloads external tarballs now must provide SHA-256; otherwise the build fails.
What type of PR is this?
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #
Other notes for review