Fix target name for meson_with_requirements #1405
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meson_with_requirements has a small quirk where the resulting rule name ends up with an '_' postfixed to the end. This is unexpected and a bit annoying when the meson project is a dependency of another rule since you have to remember to add the _ in any include paths etc.
This reverts commit f828671.
|
Just checking if my changes actually introduced the errors in CI which seems to be the case. @jheaff1 it has been a long time since you added this code, but do have any idea why it is necessary? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meson_with_requirementshas a small quirk where the resulting rule name ends up with an '_' postfixed to the end. This is unexpected and a bit annoying when the meson project is a dependency of another rule since you have to remember to add the _ in any include paths etc.