Skip to content
This repository was archived by the owner on Feb 2, 2022. It is now read-only.

updated functions of matplotlib and little more#95

Closed
ipostuma wants to merge 1 commit into
bastula:masterfrom
ipostuma:master
Closed

updated functions of matplotlib and little more#95
ipostuma wants to merge 1 commit into
bastula:masterfrom
ipostuma:master

Conversation

@ipostuma
Copy link
Copy Markdown

@ipostuma ipostuma commented Jul 7, 2016

Dear Bastula, I had some problems loading the app with matplotlib > 1.1 and there were some old functions in other libraries that I had to change to make it work.

for me it works well right now !

@bastula
Copy link
Copy Markdown
Owner

bastula commented Jul 9, 2016

Thanks for the pull request! I am working on some major changes in https://github.com/dicompyler/dicompyler-core, so once those are done I will take a look at yours as well as the ones from #94.

Copy link
Copy Markdown

@chaberb chaberb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is hard to follow the Pull Request as there is more than 3400 new lines in one commit. Maybe if you could split the changes into different commits it would be easier to review.

I also see that you pushed your *.pyc files (probably by accident). Please, remove them push this action as another commit.

@chaberb
Copy link
Copy Markdown

chaberb commented Oct 13, 2016

As I can see, #94 and this PR share some of the changes.

@bastula
Copy link
Copy Markdown
Owner

bastula commented Jul 17, 2017

Based on the discussion in #103 it is probably best for the user base for dicompyler to move forward as Python 3 only. Please see the dependencyupdate branch for that work.

Thanks for your pull request.

@bastula bastula closed this Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants