Skip to content

Conversation

@thibaut1304
Copy link
Contributor

Description

Fixed the counting of "inactive" alerts
Previously: only firing and pending alerts were counted from /api/v1/alerts

Fix: Added a call to /api/v1/rules to iterate through groups[].rules[] and filter those with state: inactive.
Corrected display in the badge ({{ count }}) and in the text (x inactive alerts).

Added the Prometheus version (buildinfo) on desktop only.
New query to /api/v1/status/buildinfo.
Mobile detected via window.matchMedia.

Visual UX improvement
The API status is initialized to null (instead of an empty object), which prevents the badge from flashing or alerts with a default value of 0 at startup.

For your information:
Note on Prometheus Basic Authentication
Limitation of Prometheus + Basic Auth + CORS:
When using Authorization: Basic, the browser first sends an OPTIONS request (pre-flight CORS) without an authentication header. Prometheus rejects this with a 401 without CORS headers, thus blocking the actual request.
Result: It is impossible to use the Prometheus API directly from the browser with Basic Auth.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

@thibaut1304
Copy link
Contributor Author

For the commit: f53e3f6
The 2 rules in the wireguard group were personal tests, they do not work and therefore we can consider them as inactive!

@thibaut1304
Copy link
Contributor Author

Capture d'écran 2025-07-05 010838
Capture d'écran 2025-07-05 010517
Capture d'écran 2025-07-05 010649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant