This repository was archived by the owner on Apr 21, 2021. It is now read-only.
Filter out 'blob' response types#4
Open
That-David-Guy wants to merge 7 commits into
Open
Conversation
bassettsj
suggested changes
Mar 23, 2018
bassettsj
left a comment
bassettsj
left a comment
Owner
There was a problem hiding this comment.
Just fix the code style issues and I can merge. It might be best to fork this and republish for your own needs. I am not actively maintaining this anymore.
|
|
||
| # Compiled scripts shouldn't be needed | ||
| lib | ||
| # lib |
Owner
There was a problem hiding this comment.
Don’t add compiled scripts please
| { | ||
| "name": "protractor-intercept", | ||
| "version": "1.0.2", | ||
| "version": "1.1.2", |
Owner
There was a problem hiding this comment.
Don’t update the version I can republish after merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using your library but it throws an error if the response type if 'blob'. In our situation it was easiest to modify your code to ignore 'blob'.
I made a pull request in case you think its suitable for the main repo.