Addressed issues when running basic-memory on the Windows platform #252
+93
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich are - In contrast to Linux where newlines contain \n on Windows newlines contain \r\n - Normalized path separators to posix '/' Signed-off-by: Manuel Bliemel <[email protected]>
…lity Signed-off-by: Manuel Bliemel <[email protected]>
|
|
Signed-off-by: Manuel Bliemel <[email protected]>
Signed-off-by: Manuel Bliemel <[email protected]>
|
@claude can you do a code review on this PR and also suggest a workflow where we can test in a windows env during our CI/CD flow? |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...which are
Tests were succeeding with my changes based on commit b0cc559 but tests are failing on current HEAD of main and therefore also on this branch after merging main.