Skip to content

Conversation

marlondecol
Copy link

This pull request proposes support for additional names for the settings file.

In addition to bashly-settings.yml and settings.yml, Bashly would also support bashlyrc.yml, as well as dotted versions of all three. This means it would recognize the following files, in this order, as the settings file:

  • .bashly-settings.yml
  • bashly-settings.yml
  • .bashlyrc.yml
  • bashlyrc.yml
  • .settings.yml
  • settings.yml

Note that bashly.yml (and its dotted version) was intentionally excluded to avoid confusion with the main configuration file.

This naming format tries to follow a convention adopted by other tools. While it is not a strict rule, I believe other developers might appreciate the added flexibility.

These naming choices are arbitrary. Any feedback or suggestions are welcome.


This was my first experience with Ruby, so I hope this doesn't cause any issues! 🙂

@DannyBen
Copy link
Member

Hey Marlon,

Thank you for your contribution. I appreciate the time and effort you put into this PR, especially since you mentioned that this is your first experience with Ruby - you've done a great job with it.

That said, I won't be able to merge this particular PR. The reason is that the project's settings file mechanism is intentionally limited to settings.yml and bashly-settings.yml. Bashly is designed to work in a structured directory workspace, so straightforward filenames like settings.yml make sense. Filenames such as *rc files or hidden dotfiles don't fit as well with this approach, and I'd like to keep the scope focused and consistent.

For future changes that might affect core behavior, it's usually best to open an issue or start a discussion first. That way we can talk through the approach together before diving into implementation.

I hope this won't discourage you from contributing again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants