[Trix input] - max height and scroll set.#58
Open
milos-dukic wants to merge 1 commit intobasecamp:mainfrom
Open
[Trix input] - max height and scroll set.#58milos-dukic wants to merge 1 commit intobasecamp:mainfrom
milos-dukic wants to merge 1 commit intobasecamp:mainfrom
Conversation
milos-dukic
force-pushed
the
trix-editor-max-height
branch
from
4e67125 to
aa508bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI/UX improvemnent of the text editor component in use i.e. Trix editor.
Namely, when you start typing the message in the editor, as the message grows so does the editor's UI, up to a point that it can become as big as chat panel, and as such it obscures the previous messages i.e. chat history.
As I am aware Trix editor doesn't have regular setup for the rows, but this is achieved via CSS.
Now just to compare:
After the above threshold is breached, we get the scrollbar for the input text field for the above apps.
Unfortunately, Campfire doesn't have this limmit.
So, I would suggest, for the sake of better UX to make some limmits for the UI input.
It doesn't have to be so restrictive as MS Teams, but I think that it should be less then in Slack.
So, my suggestion would be to limmit it to 15 lines, that would be
360px, that would be equal to2116 characters, without scrolling (that is on most of the laptop/desktop displays).