Add members_hash for O(1) direct room lookup#164
Open
ashwin47 wants to merge 1 commit intobasecamp:mainfrom
Open
Add members_hash for O(1) direct room lookup#164ashwin47 wants to merge 1 commit intobasecamp:mainfrom
ashwin47 wants to merge 1 commit intobasecamp:mainfrom
Conversation
Replace O(n) scan through all direct rooms with indexed hash lookup. The hash is computed from sorted user IDs, enabling instant room discovery when starting DMs. Includes migration to backfill existing rooms and fallback logic for gradual population. Fixes the FIXME comment about performance with 10K+ direct rooms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Finding existing DM rooms scans ALL direct rooms in memory (O(n)):
Solution
Add indexed members_hash column for O(1) lookup:
Impact Area
Starting a DM conversation (Rooms::DirectsController#create)
Migration