[Feature - Inline Audio Message] - Mini audio player added if message is audio. #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milos-dukic
force-pushed
the
feature-inline-audio-playback
branch
from
b4e34eb to
cef134b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a PR for the issue #99 .
If the message is audio, sound bar will appear, and will animate during the play time.
The message is not auto-played, it has to be triggered by the user.
Also the length of the message is displayed at the bottom of the message bubble.
Preview:
Files afected:
app/assets/stylesheets/soundbar.css- new animation effectsapp/helpers/messages/attachment_presentation.rb- newaudio_preview_tagmethod added.app/javascript/controllers/sound_controller.js- existing controller updatedCheers!