-
Notifications
You must be signed in to change notification settings - Fork 726
Port Omarchy theme management to Omakub #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Prompts user for theme name and git repository URL - Clones the theme repo if not already present - Creates or updates gnome.sh and tophat.sh scripts with correct content and executable permissions - Adds the new theme to the Omakub themes list only if missing - Provides user feedback and reloads the main menu after completion - Ensures idempotency to avoid redundant changes on repeated runs
- Includes 'Import' as a selectable item in the gum choose prompt - Allows sourcing the corresponding import.sh script when selected
Introduces a new script, `theme.sh`, to centralize and manage the active theme in the installation process. The script performs the following actions: * Creates symbolic links for all available themes to a central location (`~/.config/omakub/themes`). * Sets the initial theme to `tokyo-night` by linking theme files and a background image to `~/.config/omakub/current`. * Automates the application of the current theme to the following tools: * Alacritty * Zellij * Neovim * Btop (with a check for theme availability) * Sources separate scripts to handle theme application for Gnome, Tophat, and VS Code. This change provides a single point of truth for theme configuration, making it easier to maintain and update the system's appearance.
ln -snf ~/.config/omakub/current/theme/alacritty.toml ~/.config/alacritty/theme.toml | ||
|
||
ln -snf ~/.config/omakub/current/theme/zellij.kdl ~/.config/zellij/themes/$INITIAL_THEME.kdl | ||
sed -i "s/theme \".*\"/theme \"$INITIAL_THEME\"/g" ~/.config/zellij/config.kdl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about that, is there a smarter/simple way to achieve the same?
migrations/1754833639.sh
Outdated
#!/bin/bash | ||
|
||
# The the new theme management feature directories are created | ||
source $OMAKUB_PATH/install/desktop/theme.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When ppl run migrations this would change the current theme to tokio-night, not a big issue but maybe could be improved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can let the user choose his current theme (with gum) and use that value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed with gum that the user can choose between the omakub themes 😄
I have an idea on how to improve, I'll take some time to get back to the PC and see if I can help you! 🦾 |
love to see it :) |
Enhance Omakub with Omarchy theme system
Changes:
This change provides a single point of truth for theme configuration, making it easier to maintain and update the system's appearance.
Introduces a new script,
install/desktop/theme.sh
, to centralize and manage the active theme in the installation process.The script performs the following actions:
~/.config/omakub/themes
).tokyo-night
by linking theme files and a background image to~/.config/omakub/current
.Alter the existing script
bin/omakub-sub/theme.sh
, to change the theme with symlinks instead of copying files arround~/.config/omakub/themes
) to the current user theme (~/.config/omakub/current/theme
).Alter existing script
themes/set-gnome-theme
to change the background with symlinkManual testing performed