-
Notifications
You must be signed in to change notification settings - Fork 819
Add card linking feature #2262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dinana
wants to merge
14
commits into
basecamp:main
Choose a base branch
from
dinana:feature/card-linking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add card linking feature #2262
+784
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows linking cards with parent/child/related relationships: - CardLink model with cycle detection for parent chains - Card::Linkable concern with toggle-style API - LinksController with turbo stream updates - Link picker modal with type tabs and search - Links display with type icons and remove buttons
- Add link.svg icon for the card linking button - Add .link-picker class with proper sizing (max-content with 28ch minimum) - Fix popup overflow by following tag-picker styling pattern - Add spacing between search input and results list
Replace Unicode arrows with proper SVG icons for link type indicators. Create arrow-down.svg by rotating arrow-up and register it in icons.css.
Replace chain link icon with arrows-horizontal for related link type. The bidirectional arrow (↔) more clearly indicates the symmetric relationship between related cards.
Replace custom link icon with a standard chain link design which is more universally recognized.
Increase size of arrows-horizontal icon to match visual weight of other link type icons (arrow-up, arrow-down).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ability to link cards together with three relationship types: parent, child, and related. Links are bidirectional - when you link Card A to Card B, both cards show the relationship.
Features
Implementation
CardLinkmodel withsource_card,target_card, andlink_typeenumCard::Linkableconcern providingparents,children,related_cardsrelationsCards::LinksControllerwith Turbo Stream responses for seamless UXScreenshots
The link section appears below the card title with:
Test plan