Actually GetAll when there are fewer than 1000 entries and FindAll when a limit is not provided#9
Open
cofl wants to merge 7 commits intobarrycarey:Developfrom
Open
Actually GetAll when there are fewer than 1000 entries and FindAll when a limit is not provided#9cofl wants to merge 7 commits intobarrycarey:Developfrom
cofl wants to merge 7 commits intobarrycarey:Developfrom
Conversation
Merge dev
…ot provided and the total count is greater than the page size
…ed when an offset was specified in the filter
Author
|
This addresses #5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while testing against the asset list on a local SnipeIT install.
In EndPointManager.GetAll, when there are fewer than 1000 assets in the system, only 50 assets (the default limit) would be included in the ResponseCollection, though the Total would still show the correct number.
In EndPointManager.FindAll, when a limit is not provided, again at most only 50 assets would be included in the ResponseCollection, even when the results should have more, such as when retrieving all assets of a certain manufacturer.
Replication steps
I did my testing in PowerShell.