fix(config): correct off-by-one error in shmemlist_size#85
Merged
Conversation
lbmeng
requested review from
danielRep,
josecm and
miguelafsilva5
as code owners
Member
|
Thanks @lbmeng, that’s a good catch! I’d suggest keeping |
The example configuration defines `shmemlist_size` as N, but enumerates members [0] through [N], which actually results in N+1 items. Adjust the index to use N-1 instead, and to ensure consistency with `vmlist_size`, change NUM_VMs and the comment too. Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Contributor
Author
|
Thanks for the suggestion. I've changed the description of vmlist too for consistenty. |
danielRep
approved these changes
Feb 16, 2026
Member
|
@josecm ping |
Diogo21Costa
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example configuration defines
shmemlist_sizeas N, but enumerates members [0] through [N], which actually results in N+1 items.Adjust the value to use NUM_SHMEMs instead, ensuring consistency with how NUM_VMs is documented.