Skip to content

🐛 fix(core): Cannot build after upgrade 19.2.0 to 19.3.0 #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/pr-comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ jobs:

- name: Build
run: npx nx run-many -t build --projects=tag:scope:release
env:
BAL_DS_RELEASE: true

- name: Pre-Publish
run: npx nx run pre-publish
Expand Down
75 changes: 0 additions & 75 deletions packages/core/src/components.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1124,39 +1124,6 @@ export namespace Components {
*/
"space": BalProps.BalDividerSpace;
}
interface BalDocApp {
/**
* Disables all animation inside the bal-app. Can be used for simplify e2e testing.
* @default true
*/
"animated": boolean;
"language"?: string;
/**
* @default ''
*/
"logComponents": string;
/**
* @default true
*/
"logCustom": boolean;
/**
* @default true
*/
"logEvents": boolean;
/**
* @default true
*/
"logLifecycle": boolean;
/**
* @default true
*/
"logRender": boolean;
"region"?: string;
/**
* @default false
*/
"stickyFooter": boolean;
}
interface BalDropdown {
/**
* Indicates whether the value of the control can be automatically completed by the browser.
Expand Down Expand Up @@ -4930,12 +4897,6 @@ declare global {
prototype: HTMLBalDividerElement;
new (): HTMLBalDividerElement;
};
interface HTMLBalDocAppElement extends Components.BalDocApp, HTMLStencilElement {
}
var HTMLBalDocAppElement: {
prototype: HTMLBalDocAppElement;
new (): HTMLBalDocAppElement;
};
interface HTMLBalDropdownElementEventMap {
"balChange": BalEvents.BalDropdownChangeDetail;
"balFocus": BalEvents.BalDropdownFocusDetail;
Expand Down Expand Up @@ -5917,7 +5878,6 @@ declare global {
"bal-date-calendar": HTMLBalDateCalendarElement;
"bal-date-calendar-cell": HTMLBalDateCalendarCellElement;
"bal-divider": HTMLBalDividerElement;
"bal-doc-app": HTMLBalDocAppElement;
"bal-dropdown": HTMLBalDropdownElement;
"bal-field": HTMLBalFieldElement;
"bal-field-control": HTMLBalFieldControlElement;
Expand Down Expand Up @@ -7143,39 +7103,6 @@ declare namespace LocalJSX {
*/
"space"?: BalProps.BalDividerSpace;
}
interface BalDocApp {
/**
* Disables all animation inside the bal-app. Can be used for simplify e2e testing.
* @default true
*/
"animated"?: boolean;
"language"?: string;
/**
* @default ''
*/
"logComponents"?: string;
/**
* @default true
*/
"logCustom"?: boolean;
/**
* @default true
*/
"logEvents"?: boolean;
/**
* @default true
*/
"logLifecycle"?: boolean;
/**
* @default true
*/
"logRender"?: boolean;
"region"?: string;
/**
* @default false
*/
"stickyFooter"?: boolean;
}
interface BalDropdown {
/**
* Indicates whether the value of the control can be automatically completed by the browser.
Expand Down Expand Up @@ -10496,7 +10423,6 @@ declare namespace LocalJSX {
"bal-date-calendar": BalDateCalendar;
"bal-date-calendar-cell": BalDateCalendarCell;
"bal-divider": BalDivider;
"bal-doc-app": BalDocApp;
"bal-dropdown": BalDropdown;
"bal-field": BalField;
"bal-field-control": BalFieldControl;
Expand Down Expand Up @@ -10620,7 +10546,6 @@ declare module "@stencil/core" {
"bal-date-calendar": LocalJSX.BalDateCalendar & JSXBase.HTMLAttributes<HTMLBalDateCalendarElement>;
"bal-date-calendar-cell": LocalJSX.BalDateCalendarCell & JSXBase.HTMLAttributes<HTMLBalDateCalendarCellElement>;
"bal-divider": LocalJSX.BalDivider & JSXBase.HTMLAttributes<HTMLBalDividerElement>;
"bal-doc-app": LocalJSX.BalDocApp & JSXBase.HTMLAttributes<HTMLBalDocAppElement>;
"bal-dropdown": LocalJSX.BalDropdown & JSXBase.HTMLAttributes<HTMLBalDropdownElement>;
"bal-field": LocalJSX.BalField & JSXBase.HTMLAttributes<HTMLBalFieldElement>;
"bal-field-control": LocalJSX.BalFieldControl & JSXBase.HTMLAttributes<HTMLBalFieldControlElement>;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { Component, Host, h, Prop, ComponentInterface } from '@stencil/core'
import * as balIcons from '@baloise/ds-icons'
import { updateBalIcons } from '../../../utils/config'
import { Component, ComponentInterface, h, Host, Prop } from '@stencil/core'
import globalScript from '../../../global'
import { balBrowser } from '../../../utils/browser'
import { updateBalIcons } from '../../../utils/config'
import { BalLogger } from '../../../utils/log'
import globalScript from '../../../global'

/**
* @internal
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export {
/**
* Components
*/
export * from './components'
export { Components, JSX } from './components'

/**
* Types
Expand Down
4 changes: 2 additions & 2 deletions packages/core/stencil.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ import { sass } from '@stencil/sass'
import fg from 'fast-glob'
import { join, parse, resolve } from 'path'

import { webOutputTarget } from '@baloise/output-target-web'
import { CustomDocumentationGenerator } from './config/doc-output-target'
import { AngularGenerator, AngularModuleGenerator } from './config/stencil.bindings.angular'
import { ReactGenerator } from './config/stencil.bindings.react'
import { CustomDocumentationGenerator } from './config/doc-output-target'
import { webOutputTarget } from '@baloise/output-target-web'

const IS_BAL_DS_RELEASE = process.env.BAL_DS_RELEASE === 'true'
const IS_BAL_DOCUMENTATION = process.env.BAL_DOCUMENTATION === 'true'
Expand Down