Skip to content

♿ a11y(bal-nav): button overlays not reachable via keyboard #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

♿ a11y(bal-nav): button overlays not reachable via keyboard #1619

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6983b36
Create PR for #1415
github-actions[bot] Feb 13, 2025
29a129a
fix: make it more bulletproof to changes of aria props from outside o…
m4rc0z Feb 13, 2025
747843d
Merge branch 'main' into fix/issue-1415
hirsch88 Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions packages/core/src/components/bal-button/bal-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
ComponentInterface,
Element,
State,
Listen,
Listen, Watch,
} from '@stencil/core'
import { Attributes, inheritAttributes } from '../../utils/attributes'
import { ariaBooleanToString } from '../../utils/aria'
Expand Down Expand Up @@ -118,7 +118,7 @@ export class Button implements ComponentInterface {
/**
* If `true` the button is a popup.
*/
@Prop() balPopup = undefined
@Prop() balPopup: boolean|undefined = undefined

/**
* Name of the left button icon
Expand Down Expand Up @@ -185,11 +185,6 @@ export class Button implements ComponentInterface {

componentDidLoad(): void {
rOnLoad(() => (this.isLargestContentPaintDone = true))
if (this.el.getAttribute('bal-popup') && !this.aria?.haspopup) {
this.aria = {
haspopup: 'true',
}
}
}

componentWillLoad() {
Expand Down Expand Up @@ -313,7 +308,7 @@ export class Button implements ComponentInterface {
'aria-label':
this.aria?.label || this.inheritAttributes['aria-label'] || this.aria?.title || this.inheritAttributes['title'],
'aria-controls': this.aria?.controls || this.inheritAttributes['aria-controls'],
'aria-haspopup': this.aria?.haspopup || this.inheritAttributes['aria-haspopup'],
'aria-haspopup': ariaBooleanToString(this.balPopup) || this.inheritAttributes['aria-haspopup'],
}

return (
Expand Down
Loading