Milestone Escrow - #1049
Merged
Merged
Conversation
Contributor
|
@Dev-journals it's remaining one more check |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds backend support for scholarship milestone escrow creation and release. When a
scholarship_treasury.execute_proposalevent occurs, the server now records theescrowon-chain and persists it in the new escrows table. Milestone approval is also wired to callrelease_trancheon active escrows, while existing reclaim logic remains intact.Type of Change
Checklist
cargo testpassesnpm run typecheckpassesnpm testpassesScreenshots (if applicable)
Testing
Result:
2 test suites passed
35 tests passed
Additional Notes
Closes #1016
@Anuoluwapo25 Kindly review and merge