Remove over-matching "**/build/**" pattern from alwaysIgnore.ts#41
Open
fALKENdk wants to merge 1 commit intobacknotprop:mainfrom
Open
Remove over-matching "**/build/**" pattern from alwaysIgnore.ts#41fALKENdk wants to merge 1 commit intobacknotprop:mainfrom
fALKENdk wants to merge 1 commit intobacknotprop:mainfrom
Conversation
The "**/build/**" pattern ignores any folder named "build" at any depth. This hides valid source directories if they happen to be named "build", and those files cannot be added manually in Power Tower. Kept "build/" to ignore only the root-level build folder, which is typical for build output, while allowing other "build" folders to be visible. Why: Prevent hiding valid source folders named "build"
Owner
|
@fALKENdk do you have an example open source repo. Im worried about monorepos. I can also make a better way to disable builtins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed the ignore list in alwaysIgnore.ts has this glob:
"**/build/**".This ends up ignoring any folder named
buildanywhere in a project — even if it’s just a normal source folder and not build output. That means those files won’t show up in Power Tower and can’t be added manually.This PR changes it so only the root-level
build/folder is ignored. That should still cover normal build output, but won’t hide otherbuildfolders that are part of the source.