Open
Conversation
necipsagiro
requested review from
jeremy-babylonlabs and
kirugan
as code owners
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for the new /v2/apr endpoint, which calculates personalized staking APR based on a user's BTC and BABY stake amounts. The changes include both e2e tests for the HTTP endpoint and unit tests for the APR calculation logic.
- E2E tests validate endpoint parameter validation and error handling
- Unit tests verify APR calculation functions handle edge cases correctly
- Tests follow established patterns in the codebase for consistency
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/api/v2_test.go | Adds e2e tests for /v2/apr endpoint covering parameter validation (invalid types, negative values) and expected service errors when BBN client is unavailable |
| internal/v2/service/stats_test.go | Adds unit tests for calculateUserCoStakingAPR and calculateBoostCoStakingAPR functions, testing zero value edge cases and correct calculation with valid inputs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kirugan
reviewed
Dec 16, 2025
kirugan
reviewed
Dec 16, 2025
kirugan
reviewed
Dec 16, 2025
jrwbabylonlab
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit and e2e tests for the
/v2/aprendpoint and APR calculation functionsresolves: #420