-
Notifications
You must be signed in to change notification settings - Fork 13
Large-scale Code Refactoring for Better Architecture #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
Feb 20, 2025
Merged
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Mar 6, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [babarot/gomi](https://github.com/babarot/gomi) | minor | `v1.4.3` -> `v1.5.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>babarot/gomi (babarot/gomi)</summary> ### [`v1.5.1`](https://github.com/babarot/gomi/blob/HEAD/CHANGELOG.md#v151---2025-02-23) [Compare Source](babarot/gomi@v1.5.0...v1.5.1) ##### New Features - Add Log Rotation feature by [@​babarot](https://github.com/babarot) in babarot/gomi#82 ### [`v1.5.0`](https://github.com/babarot/gomi/blob/HEAD/CHANGELOG.md#v150---2025-02-21) [Compare Source](babarot/gomi@v1.4.3...v1.5.0) ##### New Features - Add Permanent Deletion Feature with Confirmation Dialog by [@​babarot](https://github.com/babarot) in babarot/gomi#79 ##### Refactorings - Large-scale Code Refactoring for Better Architecture by [@​babarot](https://github.com/babarot) in babarot/gomi#81 ##### Others - Create missing log path by [@​kariudo](https://github.com/kariudo) in babarot/gomi#80 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODIuNCIsInVwZGF0ZWRJblZlciI6IjM5LjE4Mi40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a significant refactoring of the codebase to improve maintainability and code organization.
Major Architectural Changes
File Organization
model.go
: Core model definitions and initializationcommands.go
: Command-related functionsmessages.go
: Message type definitionsview.go
,view_detail.go
,view_confirm.go
: View-specific rendering logicstate.go
: State managementupdate.go
: Update logic for different view statesKey Architecture Improvements
ViewState
struct for better state managementkeymap.go
styles.go
Code Structure
Benefits
This refactoring lays a stronger foundation for future feature development and maintenance.