optional IfcCurveBoundedPlane.InnerBoundaries and cardinality 1 to many#850
Open
SergejMuhic wants to merge 1 commit intotunnelfrom
Open
optional IfcCurveBoundedPlane.InnerBoundaries and cardinality 1 to many#850SergejMuhic wants to merge 1 commit intotunnelfrom
SergejMuhic wants to merge 1 commit intotunnelfrom
Conversation
TLiebich
requested changes
Jun 26, 2024
Collaborator
TLiebich
left a comment
There was a problem hiding this comment.
I would disagree to the proposed change, since it creates a non-upward compatible change in regard to IFC4.3. The SPF notation would change from [] "empty set" to $ "non asserted set" and at least under previous considerations this is not upward compatible.
(the original SET[0:?] also comes from P42).
Personally I would recommend to wait until the next major IFC release to make this kind of changes.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

closes #660
implementing proposal from @iegorychev